methods - trouble getting results from rock paper scissors code (java) -


so when run code, keeps saying tie because think there problem in 1 of methods.

here whole code:

   string userchoice = "";         string computerchoice = "";         system.out.println("welcome rock, paper, scissors.");         system.out.println("the rules of game rock breaks scissors, "                 + "scissors cut paper, , paper covers rock. in game, "                 + "the user play against computer.");         system.out.println("the legend game is: r = rock, p = paper,"                 + " , s = scissors.");          generateuserchoice();         generatecomputerchoice();         determiningoutcome(userchoice, computerchoice);         repeatgame(userchoice, computerchoice);      }      public static string generatecomputerchoice() {         string computerchoice = "";         int computerintchoice;          random generator = new random();         computerintchoice = generator.nextint(3) + 1;          if (computerintchoice == 1) {             computerchoice = "r";         } else if (computerintchoice == 2) {             computerchoice = "p";         } else if (computerintchoice == 3) {             computerchoice = "s";         }         system.out.println("the computer played "  + computerchoice);         return computerchoice;      }      public static string generateuserchoice() {         string userchoice;         scanner input = new scanner(system.in);         system.out.println("please enter choice:");         userchoice = input.nextline();         userchoice = userchoice.touppercase();          return userchoice;      }      public static void determiningoutcome(string userchoice, string computerchoice) {          if (userchoice.equals(computerchoice)) {             system.out.println("it tie!");         } else if (userchoice.equalsignorecase("r") && computerchoice.equalsignorecase("s")) {             system.out.println("rock beats scissors, win!!");         } else if (userchoice.equalsignorecase("p") && computerchoice.equalsignorecase("r")) {             system.out.println("paper beats rock, win!!");         } else if (userchoice.equalsignorecase("s") && computerchoice.equalsignorecase("p")) {             system.out.println("scissors beats paper, win!!");         } else if (computerchoice.equalsignorecase("r") && userchoice.equalsignorecase("s")) {             system.out.println("rock beats scissors, lose.");         } else if (computerchoice.equalsignorecase("p") && userchoice.equalsignorecase("r")) {             system.out.println("paper beats rock, lose.");         } else if (computerchoice.equalsignorecase("s") && userchoice.equalsignorecase("p")) {             system.out.println("scissors beats paper, lose.");         } else {             system.out.println("sorry, invalid choice.");         }     }      public static int repeatgame(string userchoice, string computerchoice) {         int playagain;          scanner input = new scanner(system.in);              system.out.println("would play again? 1 = yes , 2 = no");         playagain = input.nextint();          if (playagain == 1) {        system.out.println("would play again? 1 = yes , 2 = no");             generateuserchoice();             generatecomputerchoice();             determiningoutcome(userchoice, computerchoice);          }else {             system.out.println("thank playing!!");         }      return playagain;         }      }

however think problem in generatecomputerchoice part of code

thanks in advance

the problem userchoice , computerchoice been empty therefore tie.

you need assign userchoice , computerchoice return value of methods.

like this:

userchoice = generateuserchoice(); computerchoice = generatecomputerchoice();

Comments

Post a Comment

Popular posts from this blog

shopping cart - Page redirect not working PHP -

im trying redirect user when click "empty cart". redirect working "add cart" not "empty cart". ideas great. in main .php file set current url seen $current_url = base64_encode("http://$_server[http_host]$_server[request_uri]"); then below cartaction.php file handles actions such "add cart" , "empty cart" <?php session_start(); include_once 'config.php'; //add item in shopping cart if(isset($_post["add"])) { $product_id = $_post["product_id"]; //product id $return_url = base64_decode($_post["return_url"]); //return url $qty = $_post["qty"]; $product = $mysqli->query("select product_name, unit_price, unit_quantity products product_id = '$product_id'"); $obj = $product->fetch_object(); if(!isset($_session['products'])) { $_session['products'] = array(); } if(array_key_exists($product_id...
Read more

php - How to modify a menu to show sub-menus -

i have custom php menu made person, displays categories menu. however, need display subcategories well. tried adding hierarchical parameter didn't work. hoping assistance! here code: <ul> <?php /* categories wp e-commerce products */ $wpec_product_categories = get_terms( 'wpsc_product_category', 'hide_empty=0&parent=0&exclude=298'); $myarray = array(); foreach($wpec_product_categories $wpec_categories){ $myarray[$wpec_categories->term_id]['name'] = $wpec_categories->name; $myarray[$wpec_categories->term_id]['slug'] = $wpec_categories->slug; $myarray[$wpec_categories->term_id]['term_id'] = $wpec_categories->term_id; } foreach($myarray $wpec_categories1){ $wpec_term_name = $wpec_categories1['name']; $wpec_term_slug = $wpec_categories1['slug']; $wpec_term_id = $wpec_categories1['term_id']; echo '<li> <a href="'.get_page_link(19)....
Read more

python - Installing PyDev in eclipse is failed -

unable read repository @ http://pydev.sf.net/updates/content.xml. sun.security.validator.validatorexception: pkix path building failed: sun.security.provider.certpath.suncertpathbuilderexception: unable find valid certification path requested target i installing pydev in eclipse using python, doesn't install successfully. gives above error. happened? how solve error? i had error when trying install on laptop behind corporate firewall. couldn't tell setup of firewall, not sure of root cause. i got passed error installing pydev eclipse when out behind firewall. another way got around have eclipse on non-firewalled machine, install pydev eclipse, , copy whole eclipse directory non-firewalled machine firewalled machine. there better way, , way fix properly, didn't have time work out firewall doing. this on windows 7 machine (yeah know) not work *nix versions installed through package manager yum or apt.
Read more