java - Method returns before executing all threads even though executor.awaitTermination is used -


i have method takes number of threads work , executes run() method each thread accordingly shown below

public static map<string, integer> execute(int thread_count) {         executorservice executor = executors.newfixedthreadpool(thread_count);         file folder = new file("logfiles/");                collection<file> files = fileutils.listfiles(folder, null, true);              for(file file : files){             //for rach file in folder execute run()             system.out.println(file.getname());             executor.submit(new runner((file.getabsolutepath())));         }          executor.shutdown();         try {             executor.awaittermination(1, timeunit.days);         } catch (interruptedexception e) {             system.out.println("exception "+ e + " in countlines.execute()");         }         for(map.entry<string, integer> entry: runner.linecountmap.entryset()){             system.out.println(entry.getkey() + " : : " + entry.getvalue());         }         return runner.linecountmap;// printing after threads finish executing     }

and run method defined below:

public void run() {         try {             count = countlines(file);//get number of lines in file         } catch (ioexception e) {             system.out.println("exception "+ e + " in runner.run()");         }         //count number of lines in each file , add map         linecountmap.put(file, count);     }

as have used executor.awaittermination in execute() method above, expecting linecountmap populated filesnames key , line count values. seems linecountmap being returned before threads executed.

for following files:     logtest.2014­-07-­04.log     logtest.2014­-07-­02.log     logtest.2014­-07-­01.log     logtest.2014­-07-­03.log  expected output:  linecountmap: /logtest.2014­-07-­01.log : : 4 /logtest.2014­-07-­02.log : : 8 /logtest.2014­-07-­03.log : : 2 /logtest.2014­-07-­04.log : : 1  actual output:  linecountmap: /logtest.2014­-07-­01.log : : 4 /logtest.2014­-07-­03.log : : 2 /logtest.2014­-07-­04.log : : 0

here i missing content /logtest.2014­-07-­02.log , value /logtest.2014­-07-­04.log shown 0 when 1

changing linecountmap concurrenthashmap solved issue. oliver croisier solution discussed in comments section.


Comments

Post a Comment

Popular posts from this blog

jquery - How do you format the date used in the popover widget title of FullCalendar? -

Image
in fullcalendar, how format date used in popover widget title when clicking '+n more'? code: <div class="fc-popover fc-more-popover"> <div class="fc-header fc-widget-header"> <span class="fc-close fc-icon fc-icon-x"></span> <span class="fc-title">tuesday, april 7</span> ... </div> ... </div> you use daypopoverformat that. determines date format of title of popover created eventlimitclick option. must date formatting string. default value "dddd, mmmm d" english , "ll" other languages.
Read more

Bubble Sort Manually a Linked List in Java -

Image
this first question here. trying manually sort linked list of integers in java , can not figure out wrong code. suggestions? don't error, still have output unordered. tried few different ways, nothing worked. appreciate if can me that. public class node { int data; node nextnode; public node(int data) { this.data = data; this.nextnode = null; } public int getdata() { return this.data; } } // node class public class datalinkedlist implements datainterface { private node head; private int size; public datalinkedlist(){ this.head = null; this.size = 0; } public void add(int data) { node node = new node(data); if (head == null) { head = node; } else { node currentnode = head; while(currentnode.nextnode != null) { currentnode = currentnode.nextnode; } currentnode.nextnode = node; ...
Read more

asp.net mvc - SSO between MVCForum and Umbraco7 -

i need integrate sso between mvcforum (forum of company) , umbraco7 (manages cms company). however struggling shared authentication work. tried several ways suggested on other threads still not running expected. here did: 1. in mvcforum (forum.mywebsite.com) 1.1. machine key in web.xml: <machinekey validationkey="the same key umbraco7" decryptionkey="the same key umbraco7" validation="sha1" decryption="aes" /> 1.2. authenticate forms in web.xml <forms name="my-sso-auth" protection="all" path="/" timeout="43200" domain="forum.mywebsite.com" loginurl="/members/logon" enablecrossappredirects="true" /> 2. in umbraco7 (news.mywebsite.com) 2.1. machine key in web.xml: <machinekey validationkey="the same key mvcforum" decryptionkey="the same key mvcforum" validation="sha1" decryption="aes" /> 2.2. a...
Read more