jquery - Change CSS based on scroll position -- Refactoring bad code -


i have written jquery function changes css value of nav menu item based on if reference section viewable in window.

$(window).scroll(function() {      var scroll = $(window).scrolltop();      if (scroll <= 590) {         $("#menu-item-25 a").addclass('blue');         $("#menu-item-26 a").removeclass('blue');         $("#menu-item-22 a").removeclass('blue');         $("#menu-item-23 a").removeclass('blue');         $("#menu-item-24 a").removeclass('blue');     }     else if (scroll >= 591 && scroll <= 1380) {         $("#menu-item-26 a").addclass('blue');         $("#menu-item-25 a").removeclass('blue');         $("#menu-item-22 a").removeclass('blue');         $("#menu-item-23 a").removeclass('blue');         $("#menu-item-24 a").removeclass('blue');     }     else if (scroll >= 1381 && scroll <= 2545) {         $("#menu-item-22 a").addclass('blue');         $("#menu-item-25 a").removeclass('blue');         $("#menu-item-26 a").removeclass('blue');         $("#menu-item-23 a").removeclass('blue');         $("#menu-item-24 a").removeclass('blue');     }     else if (scroll >= 2546 && scroll <= 2969) {         $("#menu-item-23 a").addclass('blue');         $("#menu-item-25 a").removeclass('blue');         $("#menu-item-26 a").removeclass('blue');         $("#menu-item-22 a").removeclass('blue');         $("#menu-item-24 a").removeclass('blue');     }     else if (scroll >= 2970) {         $("#menu-item-24 a").addclass('blue');         $("#menu-item-25 a").removeclass('blue');         $("#menu-item-26 a").removeclass('blue');         $("#menu-item-22 a").removeclass('blue');         $("#menu-item-23 a").removeclass('blue');     } });

it looks awfully ugly. there better way achieve goal?

all previous answers work fine, because have multiple ways make better making changes css selectors, if calculations in scroll event, should read john resign post how deal scroll event, specially part:

it’s very, very, bad idea attach handlers window scroll event. depending upon browser scroll event can fire lot , putting code in scroll callback slow down attempts scroll page (not idea). performance degradation in scroll handler(s) result compound performance of scrolling overall. instead it’s better use form of timer check every x milliseconds or attach scroll event , run code after delay (or after given number of executions – , delay).
- john resign

so, in case go this:

html:

<div class="menu">     <a id="menu-item-22">link 1</a>     <a id="menu-item-23">link 2</a>     <a id="menu-item-24">link 3</a>     <a id="menu-item-25">link 4</a>     <a id="menu-item-26">link 5</a> </div>

jquery:

var didscroll = false;  $(window).scroll(function() {     didscroll = true; });  setinterval(function() {     if ( didscroll ) {         didscroll = false;         var $el;          //same if else statements         switch (true) {             case (scroll >= 591 && scroll <= 1380):                 $el = $("#menu-item-26 a");                 break;             case (scroll >= 1381 && scroll <= 2545):                 $el = $("#menu-item-22 a");                 break;             case (scroll >= 2546 && scroll <= 2969):                 $el = $("#menu-item-23 a");                 break;             case (scroll >= 2970):                 $el = $("#menu-item-24 a");                 break;             default: //scroll<=590                 $el = $("#menu-item-25 a");         }          //removing blue class links         $('.menu a').removeclass('blue');          //adding blue class matched element         $el.addclass('blue');     } }, 50);

Comments

Post a Comment

Popular posts from this blog

asp.net mvc - SSO between MVCForum and Umbraco7 -

i need integrate sso between mvcforum (forum of company) , umbraco7 (manages cms company). however struggling shared authentication work. tried several ways suggested on other threads still not running expected. here did: 1. in mvcforum (forum.mywebsite.com) 1.1. machine key in web.xml: <machinekey validationkey="the same key umbraco7" decryptionkey="the same key umbraco7" validation="sha1" decryption="aes" /> 1.2. authenticate forms in web.xml <forms name="my-sso-auth" protection="all" path="/" timeout="43200" domain="forum.mywebsite.com" loginurl="/members/logon" enablecrossappredirects="true" /> 2. in umbraco7 (news.mywebsite.com) 2.1. machine key in web.xml: <machinekey validationkey="the same key mvcforum" decryptionkey="the same key mvcforum" validation="sha1" decryption="aes" /> 2.2. a
Read more

Python Tkinter keyboard using bind -

i have problem using bind option can click button in keyboard, , call function once key pressed. tried taking other codes have similar purpose , saw i'm doing pretty same, though still have problem must've missed. thankful if me this. here's code: # -*- coding: utf-8 -*- #imports tkinter import * pil import imagetk, image import time import tkmessagebox #===========================================================================================================================================# #tkinter class class app(frame): def __init__(self, master=none): frame.__init__(self, master) self.pack() #===========================================================================================================================================# #game pieces classes class board: def __init__(self, rows = 7, columns = 6, picture_height = none, picture_width = none): self.rows = rows self.columns = columns self.picture
Read more

ubuntu - Selenium Node Not Connecting to Hub, Not Opening Port -

i'm trying set demo selenium grid. have digital ocean ubuntu 14.02 droplet. (i have 2 , tried set using 2 different machines got nowhere.) i'm trying run hub , node both locally. here input both hub, node, , nmap results. https://gist.github.com/mekhami/d5bbecca5ff0de9d2dc9 so, node starting tcp connection reset , port it's supposed operate on closed. i have had no luck in number of different options , configurations work. but... of course, worked randomly once. don't know why, don't know did, know 1 brief moment, node connected , saw on grid console. tried run test , went down again , i've never seen come up. please let me know more information can provide. update: randomly came online again. don't know happened, might related timeout or time_wait or going on. this because vm/server not have enough entropy available. to resolve problem, install haveged (or other similar things). the instructions of how install haveged on ubu
Read more