java - Is it better to invalidate a session in a servlet in which it is declared or in the jsp page where its values will be used? -
is better invalidate session in servlet in declared or in jsp page values used ?
i posting code of servlet below -
package controller.uploadinfo; import file.fileoperations; import java.io.ioexception; import java.io.printwriter; import javax.servlet.servletexception; import javax.servlet.http.httpservlet; import javax.servlet.http.httpservletrequest; import javax.servlet.http.httpservletresponse; import javax.servlet.http.httpsession; import controller.databaseexception.*; public class attendenceinfoupload extends httpservlet { protected void processrequest(httpservletrequest request, httpservletresponse response) throws servletexception, ioexception { response.setcontenttype("text/html;charset=utf-8"); try (printwriter out = response.getwriter()) { httpsession session; if (fileoperations.fileupload(request)) { try { fileoperations.exceltoattendence(); request.getrequestdispatcher("uploadsuccess.jsp").forward(request, response); } catch (dbexception e) { session = request.getsession(true); session.setattribute("exception",e); request.getrequestdispatcher("fileupload.jsp").forward(request, response); session.invalidate(); } } else { session = request.getsession(true); session.setattribute("exception"," file upload failed " ); request.getrequestdispatcher("fileupload.jsp").forward(request, response); } } } @override protected void doget(httpservletrequest request, httpservletresponse response) throws servletexception, ioexception { processrequest(request, response); } @override protected void dopost(httpservletrequest request, httpservletresponse response) throws servletexception, ioexception { processrequest(request, response); } @override public string getservletinfo() { return "short description"; }// </editor-fold> } in given servlet above have invalidated session right after getrequestdispatcher() in catch block. although code working, concern cause exception message loose before can displayed in jsp page. or better invalidate session declared in servlet in jsp page values displayed.
the jsp page -
<%@page contenttype="text/html" pageencoding="utf-8"%> <%@page import = "java.io.*" %> <!doctype html> <html> <head> <title>todo supply title</title> <meta http-equiv="content-type" content="text/html; charset=utf-8"> </head> <body> <h1>excel file upload example</h1> <form name="form1" method="post" action="attendenceinfoupload" enctype="multipart/form-data"> <table border="1"> <col width="120"> <tr> <td>upload excel file:</td> <td><input type="file" name="select file"/></td> </tr> <tr> <td> </td> <td><input name="" type="submit" value="upload" /></td> </tr> </table> </form> <c:if test="${not empty exception}"> <label> <font color="red"> <c:out value="error:${exception}"></c:out> </font> </label> </c:if> </body> </html> one can suggest alternate solution well?
the best solution invalidate session in servlet make sure values required jsp stored in request rather in session. because best practice put logic in beans or servlet code , keep jsps layout only.
Comments
Post a Comment